Security: GCUEngine is copyable despite owning a raw executable handle (possible double-free/UAF)#2521
Open
tomaioo wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
The `GCUEngine` class owns `tops_exec_` and destroys it in its destructor, but it does not define or delete copy/move constructors and assignment operators. The compiler-generated copy operations will shallow-copy `tops_exec_`, so multiple `GCUEngine` instances can end up destroying the same handle. This can cause double-free, use-after-free, or process crashes. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
Thanks for your contribution! |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: GCUEngine is copyable despite owning a raw executable handle (possible double-free/UAF)
Problem
Severity:
High| File:backends/gcu/custom_engine/gcu_engine.h:L22The
GCUEngineclass ownstops_exec_and destroys it in its destructor, but it does not define or delete copy/move constructors and assignment operators. The compiler-generated copy operations will shallow-copytops_exec_, so multipleGCUEngineinstances can end up destroying the same handle. This can cause double-free, use-after-free, or process crashes.Solution
Apply Rule of Five: delete copy constructor/assignment (
GCUEngine(const GCUEngine&) = delete; GCUEngine& operator=(const GCUEngine&) = delete;) and implement safe move semantics, or wraptopsExecutable_tin a unique RAII wrapper with clear ownership.Changes
backends/gcu/custom_engine/gcu_engine.h(modified)